Conversation
alamb
marked this pull request as draft
September 10, 2026 19:02
alamb
force-pushed
the
alamb/exclude-sqlparser-bench
branch
from
September 10, 2026 19:04
67ae2c6 to
229608d
Compare
alamb
changed the title
alamb
force-pushed
the
alamb/exclude-sqlparser-bench
branch
from
September 10, 2026 19:10
229608d to
0ef3024
Compare
alamb
marked this pull request as ready for review
September 11, 2026 10:45
Contributor
|
But a PNG cannot be expanded, defeating a bit the purpose of having the flamegraph in the first place. Is this done solely because of the licensing issue? |
Contributor
Author
Yes -- but note the png is only used for the docs (for instructions on how to create a full svg) Another thing we could do would be to keep the svg and exclude it from the packaging in create_tarball.sh 🤔 I can do that if you prefer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
sqlparser_bench/img/flamegraph.svg(which embeds CDDL-licensed JavaScript from Inferno) with a renderedflamegraph.png, updates the README link, and removes the flamegraph entry from the RAT exclusion list (no longer needed).