Parser: fix exponential parse time on compound chains#2344
Open
LucaCappelletti94 wants to merge 2 commits into
Open
Parser: fix exponential parse time on compound chains#2344LucaCappelletti94 wants to merge 2 commits into
LucaCappelletti94 wants to merge 2 commits into
Conversation
Dandandan
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_compound_exprrecursed intoparse_subexprafter every., which re-walks the rest of the chain inside a rollback boundary. On inputs likeIF a.b.c...x.#the work doubled per chain element, giving 2^N parse times. Switching the inner call toparse_prefixremoves the redundant traversal: the outer loop already walks the chain, so the resulting AST is identical on valid SQL.Measured on
PostgreSqlDialectwith three inputs from a libFuzzer corpus, release build:iF i.D.i.:Fi....(65 B)iF i.D.i.i. ... .*~(58 B)if-stf-localtclocal33alt....(306 B)Regression test in
tests/sqlparser_postgres.rsruns a 30-element chain with a 5 s timeout. Pre-fix it hits the timeout, post-fix it finishes in well under a millisecond.