fix: make csv-read-options.py example self-contained (#1728) - #1729
fix: make csv-read-options.py example self-contained (#1728)#1729dedsec-terminal wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The delimiter mismatch affects example correctness, and Example 3 does not execute.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Fixes examples/csv-read-options.py by making it runnable with generated temporary CSV and gzip inputs.
Changes:
- Generates temporary CSV fixtures.
- Updates reads and registrations to use them.
- Adds output display calls.
File summaries
| File | Summary |
|---|---|
examples/csv-read-options.py |
Self-contained CSV options demonstrations. Moderate finding (1 vote): delimiter does not match the generated fixture. Nit (3 votes): Example 3 needs a terminal call such as df.show(). |
Review details
Suppressed comments (1)
examples/csv-read-options.py:64
- The generated fixture is comma-separated, but this example configures
|as the delimiter. It therefore reads each row as one field instead of demonstrating a valid custom-delimiter CSV; use a pipe-delimited fixture for this example or change the delimiter to match the fixture.
.with_delimiter("|")
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: dedsec-terminal <dedsec.terminal@gmail.com>
Signed-off-by: dedsec-terminal <dedsec.terminal@gmail.com>
|
Follow-up: I executed the example end to end and found one more runtime edge case: the literal |
Which issue does this PR close?
Closes #1728.
Rationale for this change
examples/csv-read-options.pyfailed when executed because it attempted to readdata.csvanddata.csv.gzwhich do not exist in the repository.What changes are included in this PR?
examples/csv-read-options.pyself-contained by generating small temporary CSV and gzipped CSV files in atempfile.TemporaryDirectory()..show()calls to display example DataFrame outputs.Are there any user-facing changes?
No breaking changes; fixes example execution so it is runnable out of the box.