Skip to content

make password an optional parameter/field in createAccount - #13955

Open
DaanHoogland wants to merge 2 commits into
mainfrom
ghi12039-optional-password-for-saml-account
Open

make password an optional parameter/field in createAccount#13955
DaanHoogland wants to merge 2 commits into
mainfrom
ghi12039-optional-password-for-saml-account

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

Description

This PR...

Fixes: #12039

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.73%. Comparing base (158fe4f) to head (7fba665).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13955      +/-   ##
============================================
- Coverage     19.74%   19.73%   -0.01%     
+ Complexity    19960    19959       -1     
============================================
  Files          6371     6371              
  Lines        575784   575788       +4     
  Branches      70478    70481       +3     
============================================
- Hits         113665   113654      -11     
- Misses       449765   449782      +17     
+ Partials      12354    12352       -2     
Flag Coverage Δ
uitests 3.41% <ø> (-0.01%) ⬇️
unittests 21.01% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 22, 2026

Copy link
Copy Markdown

🔴 Test Coverage Grade: D — Marginal

Metric Value
Line coverage 24.61%
Branch coverage 18.82%

Grade Scale

Grade Line Coverage Meaning
🟢 A ≥ 80% Excellent - this code sleeps well at night 😴
🟡 B 60-79% Good - almost there, don't stop now 😉
🟠 C 40-59% Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D 20-39% Marginal - boldly shipping where no test has gone before 🖖
⛔ F < 20% Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

@GaOrtiga GaOrtiga left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Daan Hoogland and others added 2 commits August 25, 2026 19:00
…unt/CreateAccountCmd.java

Co-authored-by: GaOrtiga <49285692+GaOrtiga@users.noreply.github.com>
@DaanHoogland
DaanHoogland force-pushed the ghi12039-optional-password-for-saml-account branch from 86b71c7 to 7fba665 Compare August 25, 2026 17:00
@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18980

@sonarqubecloud

Copy link
Copy Markdown

@DaanHoogland

Copy link
Copy Markdown
Contributor Author

LGTM

@GaOrtiga did you happen to test?

@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

UI/API: Don't make password a mandatory parameter for the creation of LDAP/SAML account

3 participants