Skip to content

allow creating ldap on existing linked domain - #13945

Open
DaanHoogland wants to merge 3 commits into
4.20from
ghi8732-ldap-createaccount-group-scope
Open

allow creating ldap on existing linked domain#13945
DaanHoogland wants to merge 3 commits into
4.20from
ghi8732-ldap-createaccount-group-scope

Conversation

@DaanHoogland

@DaanHoogland DaanHoogland commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

allow creating ldap accounts after linking accounts to the same the domain

Description

This PR...

Fixes: #8732

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.35%. Comparing base (6136ac9) to head (00e3223).

Files with missing lines Patch % Lines
...pache/cloudstack/ldap/OpenLdapUserManagerImpl.java 92.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #13945      +/-   ##
============================================
+ Coverage     16.32%   16.35%   +0.02%     
- Complexity    13556    13583      +27     
============================================
  Files          5669     5669              
  Lines        501399   501406       +7     
  Branches      60902    60902              
============================================
+ Hits          81847    81996     +149     
+ Misses       410390   410229     -161     
- Partials       9162     9181      +19     
Flag Coverage Δ
uitests 4.14% <ø> (ø)
unittests 17.21% <92.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Daan Hoogland added 2 commits August 24, 2026 12:56
@sonarqubecloud

Copy link
Copy Markdown

@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 18985

@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@DaanHoogland DaanHoogland changed the title allow creating ldap accounts after linking accounts to the same the d… allow creating ldap on existing linked domain Aug 26, 2026
@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-16828)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55905 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13945-t16828-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

Unable to create another ldap Account if another account is linked to ldap group in the same domain

2 participants