Skip to content

[NAS Backup] Suppress Errors in Disk Usage Calculation that Caused Backup to Fail. #13424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daviftorres wants to merge 10 commits into
base: main
Choose a base branch
from
+7 −5
Open

[NAS Backup] Suppress Errors in Disk Usage Calculation that Caused Backup to Fail. #13424

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d1a8d01
Suppress errors in disk usage calculation
daviftorres Jun 15, 2026
37a93ba
Update nasbackup.sh
daviftorres Jun 17, 2026
f2eb386
Implement timeout for unmounting in nasbackup.sh
daviftorres Jun 17, 2026
258fd43
Change echo to echo -n for backup size output
daviftorres Jun 17, 2026
68c027f
Add timeout variable and log output redirection
daviftorres Jun 24, 2026
700ec76
Update nasbackup.sh
daviftorres Jun 24, 2026
b12219d
Fix output redirection in nasbackup.sh
daviftorres Jun 25, 2026
9ef5ecc
Apply suggestions from code review
daviftorres Jun 25, 2026
8f93025
fix multiline logging
abh1sar Jun 26, 2026
8dea747
Change echo to echo -n for backup size output
daviftorres Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions scripts/vm/hypervisor/kvm/nasbackup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ BACKUP_DIR=""
DISK_PATHS=""
QUIESCE=""
logFile="/var/log/cloudstack/agent/agent.log"

UNMOUNT_TIMEOUT=60
EXIT_CLEANUP_FAILED=20

log() {
Expand Down Expand Up @@ -196,10 +196,12 @@ backup_running_vm() {

# Print statistics
virsh -c qemu:///system domjobinfo $VM --completed
du -sb $dest | cut -f1

umount $mount_point
rmdir $mount_point
backup_size=$(du -sb "$dest" 2>>"$logFile" | cut -f1) || { log -ne "WARNING: du failed for $dest, reporting size as 0"; backup_size=0; }

timeout "$UNMOUNT_TIMEOUT" umount "$mount_point" 2>>"$logFile" || { log "WARNING: umount of $mount_point failed or timed out"; true; }
rmdir "$mount_point" 2>>"$logFile" || { log "WARNING: rmdir of $mount_point failed"; true; }
Comment on lines +201 to +202

echo -n "$backup_size"
}

backup_stopped_vm() {
Expand Down
Loading