Repository navigation
bench(rwlock): add upgradable lock stage timings - #405
Open
ismaeelakin wants to merge 5 commits into
Open
ismaeelakin wants to merge 5 commits into
ismaeelakin wants to merge 5 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds stage timings for the
UpgradableRwLockinvestigation in #404:--testsupport for the repository benchmark smoke runThis PR adds the measurement step requested in #404; it does not change the lock implementation or establish a speedup. Per-operation clock reads add overhead. Reader-promotion timings include dropping the readers and the wake/handoff, and queued acquisition includes the writer's handoff. The benchmark manually polls futures with a non-scheduling waker, so its timings exclude executor scheduling overhead. Treat the results as diagnostics.
Verification
Passed locally on Windows 11 (Intel Core i5-6300U):
cargo x testand benchmark runs with stable rustc 1.99.1cargo x lintwith nightly rustc 1.101.0cargo x bench -- --testcargo x bench --bench upgradable_stages -- --rounds 1000000 --repeat 5The local timings and their run-to-run spread are recorded in issue #404.
Refs #404