GH-50822 [C++][Parquet] Make DELTA_BYTE_ARRAY value reconstruction storage-agnostic - #50823
Draft
marcin-krystianc wants to merge 6 commits into
Draft
GH-50822 [C++][Parquet] Make DELTA_BYTE_ARRAY value reconstruction storage-agnostic#50823marcin-krystianc wants to merge 6 commits into
marcin-krystianc wants to merge 6 commits into
Conversation
|
|
github-actions
Bot
added
Component: Parquet
Component: C++
awaiting review
marcin-krystianc
force-pushed
the
dev-20260702-flba-decoder-follow-up
branch
from
August 6, 2026 10:02
7d36f89 to
550ba67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Follow-up to #50335.
DeltaByteArrayFLBADecoder::Decode(uint8_t*, int)decodes into atemporary
std::vector<ByteArray>and then copies the bytes into the caller's buffer,because
DeltaByteArrayDecoderImpl::GetInternalonly supportsByteArrayoutput. Thevector is a per-call allocation, and the pointer it holds for every value is discarded
immediately after the copy.
What changes are included in this PR?
TBD
Are these changes tested?
Yes
Are there any user-facing changes?
No