Fix #71125: DAG processor treats any zip-format file as a potential DAG bundle - #71204
Open
saitejabandaru-in wants to merge 3 commits into
Open
Fix #71125: DAG processor treats any zip-format file as a potential DAG bundle#71204saitejabandaru-in wants to merge 3 commits into
saitejabandaru-in wants to merge 3 commits into
Conversation
Fixes apache#71125 by explicitly checking the file extension before checking if it's a valid zip file, to prevent treating .jar, .pptx, etc. as DAG bundles.
saitejabandaru-in
requested review from
ephraimbuddy,
jedcunningham and
shahar1
as code owners
August 5, 2026 20:25
boring-cyborg
Bot
added
area:DAG-processing
area:providers
provider:google
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #71125.
zipfile.is_zipfile()is a content sniff, which means it evaluates to true for files like.jar,.pptx,.docx,.xlsxetc. since they are technically zip archives. This resulted in the DAG processor incorrectly treating them as DAG bundles, leading to wasted processing, errors, and noise.This PR updates the DAG discovery logic to ensure that a file explicitly has a
.zipextension in addition to passingzipfile.is_zipfile()before we process it as a zipped DAG bundle.Are you willing to submit a PR?
Code of Conduct