Skip to content

fix: handle 404 in checkHumanActor for bot/app actors #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saarakelyan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle 404 in checkHumanActor for bot/app actors #1213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions src/github/validation/actor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,25 @@ export async function checkHumanActor(
octokit: Octokit,
githubContext: GitHubContext,
) {
// Fetch user information from GitHub API
const { data: userData } = await octokit.users.getByUsername({
username: githubContext.actor,
});
let actorType: string;

const actorType = userData.type;
try {
const { data: userData } = await octokit.users.getByUsername({
username: githubContext.actor,
});
actorType = userData.type;
} catch (error: any) {
if (error.status === 404) {
// Bot/app actors (e.g. github-merge-queue[bot]) can't be looked up
// via the Users API — treat as a bot and fall through to allowedBots check
console.log(
`Actor "${githubContext.actor}" not found via Users API (likely a bot/app), treating as Bot`,
);
actorType = "Bot";
} else {
throw error;
}
}

console.log(`Actor type: ${actorType}`);

Expand Down