test: configure network-timeout and prefer-offline for yarn in e2e tests - #34025
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request defines a new WEBPACK_TESTS list in tests/e2e.bzl and configures webpack e2e suites to use it. It also updates the Yarn sandbox configuration in tests/e2e/setup/001-npm-sandbox.ts to include a 10-second network timeout and prefer offline mode. The reviewer suggests increasing the network timeout to 15 seconds to prevent potential test flakiness in CI environments.
alan-agius4
force-pushed
the
perf-e2e-speedup
branch
from
September 4, 2026 08:35
6fea7f7 to
e6428ea
Compare
alan-agius4
changed the title
alan-agius4
added
action: review
alan-agius4
force-pushed
the
perf-e2e-speedup
branch
from
September 4, 2026 08:49
e6428ea to
8095ae7
Compare
This glob does not match anything
alan-agius4
requested review from
clydin and
dgp1130
and removed request for
clydin and
dgp1130
September 7, 2026 13:51
clydin
approved these changes
Sep 8, 2026
alan-agius4
added
action: merge
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Yarn Classic in the E2E test sandbox defaults to a 30-second socket timeout and performs multiple sequential retries on network stalls, which can cause shards with multiple package installations to run for excessive amounts of time when external registry latency or socket stalls occur.
What is the new behavior?
Configures
.yarnrcwithnetwork-timeout 15000andprefer-offline truein the E2E npm sandbox (tests/e2e/setup/001-npm-sandbox.ts) to fail faster on stalled connections and avoid hanging during package resolution while remaining resilient to transient CI latency.Does this PR introduce a breaking change?
Other information