Skip to content

test: update e2e global npm version to 12.0.2 - #34015

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:update-npm
Sep 3, 2026
Merged

test: update e2e global npm version to 12.0.2#34015
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:update-npm

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

Updates the npm version installed in the e2e test sandbox to 12.0.2 to avoid an upstream npm 10 Arborist crash when resolving optional peer dependencies (such as during Vitest installation).

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 3, 2026
@alan-agius4
alan-agius4 requested a review from clydin September 3, 2026 14:03

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the npm package manager version in the end-to-end test setup to 12.0.2. The reviewer correctly identified that npm version 12.0.2 does not exist and will cause the setup to fail, suggesting a rollback to a valid version like 10.9.2 instead.

Comment thread tests/e2e/setup/100-global-cli.ts
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 3, 2026
Update the npm version installed in the e2e test sandbox to 12.0.2 to avoid
an upstream npm 10 Arborist crash when resolving optional peer dependencies.
@alan-agius4
alan-agius4 merged commit f6cb128 into angular:main Sep 3, 2026
39 checks passed
@alan-agius4
alan-agius4 deleted the update-npm branch September 3, 2026 14:37
@alan-agius4

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants