Skip to content

Migrate performance snippets - #1055

Open
pengzhi-cb wants to merge 5 commits into
android:mainfrom
StellarElements:katherinekuan/app-startup-snippets
Open

Migrate performance snippets#1055
pengzhi-cb wants to merge 5 commits into
android:mainfrom
StellarElements:katherinekuan/app-startup-snippets

Conversation

@pengzhi-cb

@pengzhi-cb pengzhi-cb commented Aug 28, 2026

Copy link
Copy Markdown

This PR aims to add following hard-coded snippets from DAC to repo:
(3 snippets) Analysis optimization
(2 snippets) Best practices

Summary:

  • Consolidated 2 methods that shared exact code into one.
  • Added ellipses to indicate that surrounding or existing code has been omitted for brevity.
  • Enabled build config in gradle.

@pengzhi-cb
pengzhi-cb requested a review from a team as a code owner August 28, 2026 13:54
@pengzhi-cb
pengzhi-cb requested a review from bsagmoe August 28, 2026 13:54
@snippet-bot

snippet-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla

google-cla Bot commented Aug 28, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pengzhi-cb
pengzhi-cb marked this pull request as draft August 28, 2026 14:05
@pengzhi-cb
pengzhi-cb force-pushed the katherinekuan/app-startup-snippets branch from 3e6e001 to 8f5c282 Compare August 28, 2026 14:29
@pengzhi-cb
pengzhi-cb marked this pull request as ready for review August 28, 2026 14:37
@kkuan2011
kkuan2011 requested a review from AjeshRPai August 28, 2026 15:51
@kkuan2011

Copy link
Copy Markdown
Contributor

Thanks Peng, could you rename the title of the PR to something like Migrate performance snippets? Also feel free to remove any comments in the PR description if it refers to intermediate states of the PR and is not reflected in the final code (e.g. mentions of System.gc() can be removed now). I've also added our Performance DRE, Ajesh, for review on the PR too.

@pengzhi-cb pengzhi-cb changed the title Katherinekuan/app startup snippets Migrate performance snippets Aug 28, 2026
@pengzhi-cb

pengzhi-cb commented Aug 28, 2026

Copy link
Copy Markdown
Author

Thanks Peng, could you rename the title of the PR to something like Migrate performance snippets? Also feel free to remove any comments in the PR description if it refers to intermediate states of the PR and is not reflected in the final code (e.g. mentions of System.gc() can be removed now). I've also added our Performance DRE, Ajesh, for review on the PR too.

Got it, since the final diff wouldn't show those intermediary changes and it will be confusing to reviewer. Let me remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants