Skip to content

🤖 Update Dependencies#1689

Open
compose-devrel-github-bot wants to merge 3 commits intomainfrom
bot-update-deps
Open

🤖 Update Dependencies#1689
compose-devrel-github-bot wants to merge 3 commits intomainfrom
bot-update-deps

Conversation

@compose-devrel-github-bot
Copy link
Copy Markdown
Contributor

Updated depedencies

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependency versions across multiple projects, including the Android Gradle Plugin, Compose BOM, and various AndroidX libraries. Feedback was provided regarding the versioning of androidx-tv-material, suggesting it should be synced with androidx-tv-foundation at version 1.0.0 to maintain consistency on the stable track.

Comment on lines +21 to +22
androidx-tv-foundation = "1.0.0"
androidx-tv-material = "1.1.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The androidx-tv-foundation version has been updated to a stable 1.0.0 release, but androidx-tv-material is being updated to 1.1.0. Typically, these libraries are version-synced. Using 1.1.0 without a suffix (like -alpha01) implies a stable release that may not exist yet if the foundation is only at 1.0.0. Please verify if 1.0.0 was intended for both to maintain consistency on the stable track.

Suggested change
androidx-tv-foundation = "1.0.0"
androidx-tv-material = "1.1.0"
androidx-tv-foundation = "1.0.0"
androidx-tv-material = "1.0.0"

Comment on lines +27 to +28
androidx-tv-foundation = "1.0.0"
androidx-tv-material = "1.1.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The androidx-tv-foundation version has been updated to a stable 1.0.0 release, but androidx-tv-material is being updated to 1.1.0. Typically, these libraries are version-synced. Using 1.1.0 without a suffix (like -alpha01) implies a stable release that may not exist yet if the foundation is only at 1.0.0. Please verify if 1.0.0 was intended for both to maintain consistency on the stable track.

Suggested change
androidx-tv-foundation = "1.0.0"
androidx-tv-material = "1.1.0"
androidx-tv-foundation = "1.0.0"
androidx-tv-material = "1.0.0"

Comment on lines +25 to +26
androidx-tv-foundation = "1.0.0"
androidx-tv-material = "1.1.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The androidx-tv-foundation version has been updated to a stable 1.0.0 release, but androidx-tv-material is being updated to 1.1.0. Typically, these libraries are version-synced. Using 1.1.0 without a suffix (like -alpha01) implies a stable release that may not exist yet if the foundation is only at 1.0.0. Please verify if 1.0.0 was intended for both to maintain consistency on the stable track.

Suggested change
androidx-tv-foundation = "1.0.0"
androidx-tv-material = "1.1.0"
androidx-tv-foundation = "1.0.0"
androidx-tv-material = "1.0.0"

Comment on lines +20 to +21
androidx-tv-foundation = "1.0.0"
androidx-tv-material = "1.1.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The androidx-tv-foundation version has been updated to a stable 1.0.0 release, but androidx-tv-material is being updated to 1.1.0. Typically, these libraries are version-synced. Using 1.1.0 without a suffix (like -alpha01) implies a stable release that may not exist yet if the foundation is only at 1.0.0. Please verify if 1.0.0 was intended for both to maintain consistency on the stable track.

Suggested change
androidx-tv-foundation = "1.0.0"
androidx-tv-material = "1.1.0"
androidx-tv-foundation = "1.0.0"
androidx-tv-material = "1.0.0"

Comment on lines +25 to +26
androidx-tv-foundation = "1.0.0"
androidx-tv-material = "1.1.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The androidx-tv-foundation version has been updated to a stable 1.0.0 release, but androidx-tv-material is being updated to 1.1.0. Typically, these libraries are version-synced. Using 1.1.0 without a suffix (like -alpha01) implies a stable release that may not exist yet if the foundation is only at 1.0.0. Please verify if 1.0.0 was intended for both to maintain consistency on the stable track.

Suggested change
androidx-tv-foundation = "1.0.0"
androidx-tv-material = "1.1.0"
androidx-tv-foundation = "1.0.0"
androidx-tv-material = "1.0.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants