test: make ThreadQueue waits deterministic - #680
Open
Cuiyus wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThreadQueue.GeneralandThreadQueue.MutliThreadwith condition-variable completion waits.ThreadQueueAPI and shutdown behavior unchanged.Root cause
The weekly RISC-V job failed because
ThreadQueue.MutliThreadasserted after a fixed 20 ms delay, before all 10,000 queued tasks had completed (8,909 were observed). The neighboringGeneraltest used the same timing assumption and had also failed intermittently, so both tests are made deterministic.Failing job: https://github.com/alibaba/zvec/actions/runs/31197085540/job/92996190189
Validation
cmake --build build --target thread_queue_test -j8ctest --test-dir build -R '^thread_queue_test$' --output-on-failure