Conversation
tripodsan
reviewed
Aug 18, 2026
Comment on lines
+39
to
+43
| aemHeadHtmlTree.children = aemHeadHtmlTree.children.filter( | ||
| (node) => !(node.type === 'element' | ||
| && node.tagName === 'meta' | ||
| && node.properties?.['move-to-http-header'] !== undefined), | ||
| ); |
Contributor
There was a problem hiding this comment.
should the check look for nonce-aem ?
tripodsan
reviewed
Aug 18, 2026
| const cspHead = '<meta http-equiv="Content-Security-Policy"' | ||
| + ' content="script-src \'nonce-aem\' \'strict-dynamic\';"' | ||
| + ' move-to-http-header="true" />' | ||
| + '<script nonce="aem" src="/scripts/aem.js" type="module"></script>'; |
Contributor
There was a problem hiding this comment.
shouldn't the nonce="aem" also be removed?
drops the nonce="aem" the pipeline would have rewritten, and narrows the meta drop to metas whose csp references that same placeholder. covers tobi's #273 review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
head.htmlnow comes from the config service, which serves it as the code bus holds it, so a<meta http-equiv="Content-Security-Policy" ... move-to-http-header="true">that the pipeline used to consume reached the composed page and blocked the un-nonced Universal Editor scripts.Relates to #270