Skip to content

Don't send echo=true connection param - #469

Merged
SimonWoolf merged 1 commit into
mainfrom
465-clarify-echoMessages-default
Oct 7, 2026
Merged

SimonWoolf merged 1 commit into
mainfrom
465-clarify-echoMessages-default

Conversation

@lawrence-forooghian

Copy link
Copy Markdown
Contributor

The server's default behaviour is equivalent to echo=true.

Resolves #465.

@SimonWoolf SimonWoolf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I see the need to deprecate RTN2b in favour of a new RTN2h given this is just restoring RTN2b to what it said originally, but shrug

@lawrence-forooghian

Copy link
Copy Markdown
Contributor Author

not sure I see the need to deprecate RTN2b in favour of a new RTN2h given this is just restoring RTN2b to what it said originally, but shrug

"originally" when? because as mentioned in #198 (comment), the pre-that-PR-version of that spec point also suggested you were meant to always send the param

@SimonWoolf

Copy link
Copy Markdown
Member

as mentioned in #198 (comment), the pre-that-PR-version of that spec point also suggested you were meant to always send the param

Well, it 'suggested' it in the sense that it was very poorly phrased and could be read either way

anyway, it really doesn't matter much either way, which is why I approved the PR, and that was five months ago. I'm going to merge it now

The server's default behaviour is equivalent to `echo=true`.

Resolves #465.
@SimonWoolf
SimonWoolf force-pushed the 465-clarify-echoMessages-default branch from 94814cb to fd4ca01 Compare October 7, 2026 02:00
@SimonWoolf
SimonWoolf merged commit 12540dc into main Oct 7, 2026
2 checks passed
@SimonWoolf
SimonWoolf deleted the 465-clarify-echoMessages-default branch October 7, 2026 02:01

This branch was successfully deployed

1 active deployment
staging/pull/469 — fd4ca01a Deployed Oct 7, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

RTC1a needlessly requires sending the echo param with a default value

2 participants