Skip to content

fix: update deepseek-v4-pro reasoning efforts and mappings - #1236

Open
WHMHammer wants to merge 2 commits into
Zoo-Code-Org:mainfrom
WHMHammer:upstream-pr
Open

fix: update deepseek-v4-pro reasoning efforts and mappings#1236
WHMHammer wants to merge 2 commits into
Zoo-Code-Org:mainfrom
WHMHammer:upstream-pr

Conversation

@WHMHammer

@WHMHammer WHMHammer commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Related GitHub Issue

Closes: #1235

Description

Updated the supported reasoning efforts for deepseek-v4-pro and the normalizeDeepSeekReasoningEffort function. Also updated the dates for prices (I checked https://api-docs.deepseek.com/quick_start/pricing again and the prices haven't changed).

Test Procedure

I built and installed the extension locally and confirmed that it's working fine.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Visual Snapshot (UI changes only): If a user would notice this change at a glance (layout, theme tokens, brand elements, empty/error states), I've added or updated a *.visual.tsx snapshot in webview-ui/. See webview-ui/AGENTS.md → "When a UI change needs a snapshot".
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Visual Snapshots

N/A

Videos (interaction / animation only)

N/A

Documentation Updates

N/A

Additional Notes

N/A

Get in Touch

I don't use Discord. Please comment in this PR or the linked issue. I signed up for email notifications and will respond promptly.

Summary by CodeRabbit

  • New Features

    • DeepSeek V4 Pro now supports the “low” reasoning-effort setting.
    • Reasoning-effort options are handled consistently across DeepSeek V4 Flash and V4 Pro.
  • Updates

    • DeepSeek V4 Flash and V4 Pro metadata includes updated August 2026 pricing annotations.
    • Medium and extra-high reasoning requests now map to the appropriate supported levels across both models.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8cae8ff6-eff6-428d-b3ad-418daed743f2

📥 Commits

Reviewing files that changed from the base of the PR and between 1bd5084 and 2757402.

📒 Files selected for processing (2)
  • src/api/providers/__tests__/deepseek.spec.ts
  • src/api/providers/deepseek.ts

📝 Walkthrough

Walkthrough

DeepSeek V4 metadata now reflects the August 2026 revision. V4 Pro supports low reasoning effort. Both V4 models use shared normalization for low, medium, high, xhigh, and max, with updated tests.

Changes

DeepSeek reasoning effort updates

Layer / File(s) Summary
Model metadata
packages/types/src/providers/deepseek.ts
V4 Pro now supports low. Pricing metadata comments use the 2026-08-13 revision. Pricing values remain unchanged.
Reasoning-effort normalization and tests
src/api/providers/deepseek.ts, src/api/providers/__tests__/deepseek.spec.ts
Both V4 models map low to low, medium/high/xhigh to high, and max to max. Tests cover the updated mappings and documentation date.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: awaiting-review

Suggested reviewers: taltas

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The pricing-date updates are not included in the linked issue objectives and appear unrelated to reasoning-effort mappings. Move the pricing-date updates to a separate issue or link an issue that explicitly covers the pricing metadata changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change to DeepSeek V4 Pro reasoning efforts and mappings.
Description check ✅ Passed The description includes the linked issue, implementation summary, testing notes, checklist, and documentation status.
Linked Issues check ✅ Passed The changes implement all required DeepSeek V4 Pro mappings, including medium to high, as specified in issue #1235.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/api/providers/__tests__/deepseek.spec.ts

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

src/api/providers/deepseek.ts

ESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zoomote

zoomote Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review and test-failure triage complete.

  • The live PR advanced to 2757402, which independently added the missing model guard and corrected the DeepSeek mapping tests. The focused suite passes with 30 tests passed and 1 skipped.
  • I prepared and validated the remaining cleanup locally: remove the unrelated future-dated pricing annotations while preserving the deepseek-v4-pro capability date. The full repository suite passed with 10/10 tasks and 7,370 tests; repository-wide lint and type checks also passed.
  • Push is blocked because this is a fork PR (WHMHammer/Zoo-Code:upstream-pr) and GitHub rejected the branch update with permission denied. No review threads were available to resolve.

The remaining action for the contributor is to revert the date-only pricing annotation changes, or grant maintainers write access to the PR branch so the prepared cleanup can be applied.

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions github-actions Bot added the awaiting-review PR changes are ready and waiting for maintainer re-review label Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review PR changes are ready and waiting for maintainer re-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Update deepseek-v4-pro reasoning efforts and mappings

1 participant