Skip to content

Observatory: Fix consuming 100% CPU when no outbound matches subjectSelector - #6669

Merged
RPRX merged 1 commit into
mainfrom
obs-non-selected
Aug 25, 2026
Merged

Observatory: Fix consuming 100% CPU when no outbound matches subjectSelector#6669
RPRX merged 1 commit into
mainfrom
obs-non-selected

Conversation

@Fangliding

@Fangliding Fangliding commented Aug 23, 2026

Copy link
Copy Markdown
Member

close #6666
避免忙等待

@RPRX RPRX changed the title Fix oberver consume 100% cpu if no outbound selected Observatory: Fix consuming 100% CPU when no outbound matches subjectSelector Aug 25, 2026
@RPRX

RPRX commented Aug 25, 2026

Copy link
Copy Markdown
Member

简单看了一下 burst 的代码貌似没这问题但这个

func (h *HealthPing) StartScheduler(selector func() ([]string, error)) {
函数里两处调用 selector() 返回的 tags 为零的话似乎直接抛 err 更好?你看下要不要改

我没细看,要考虑动态增删 outbounds 的情况

@RPRX RPRX changed the title Observatory: Fix consuming 100% CPU when no outbound matches subjectSelector Observatory: Fix consuming 100% CPU when no outbound matches subjectSelector Aug 25, 2026
@Fangliding

Copy link
Copy Markdown
Member Author

API增删outbound让它select不出东西是可能的 退出循环就坏了 最好还是这样抛个警告就好

@RPRX

RPRX commented Aug 25, 2026

Copy link
Copy Markdown
Member

那就先这样吧

这些连接观测的特征还是有点明显,等开发 288 刀时我才会用到,到时候整顿一下

@RPRX
RPRX merged commit f124daf into main Aug 25, 2026
47 of 48 checks passed
Maolaohei pushed a commit to Maolaohei/Bray-Core that referenced this pull request Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

observatory busy-loops at ~100% CPU indefinitely when subjectSelector matches no outbound tag

2 participants