[NOT READY YET] Build/Test Tools: Upgrade npm to v12 - #13536
Draft
manzoorwanijk wants to merge 8 commits into
Draft
manzoorwanijk wants to merge 8 commits into
manzoorwanijk wants to merge 8 commits into
Conversation
Install the npm version required by `devEngines.packageManager`, keeping the bundled npm when the field is absent. Restore the npm download cache with `actions/cache`, since `actions/setup-node` resolves it with the bundled npm. Mirrors the Gutenberg action from WordPress/gutenberg#82775 and WordPress/gutenberg#82823. See #66099.
…ction. Disable npm caching in `actions/setup-node` and run `setup-npm` before installing dependencies. Skip the action on release branches that run these workflows from `trunk` without it. Run the calling workflows when the action changes. See #66099.
Declare the same Node.js and npm requirements as Gutenberg, so CI installs the required npm version. See #66099.
This reverts commit c0d3c9f.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
manzoorwanijk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades npm to v12 for Core and the bundled themes with a build process, mirroring WordPress/gutenberg#82732. npm v12 makes dependency install scripts, git dependencies and remote URL dependencies opt-in.
Temporary test PR: it includes the commits from #13505 so CI runs npm v12. It will be rebased on
trunkonce #13505 lands.devEnginesandenginesrequire npm>=12.0.2in Core, Twenty Twenty-One, Twenty Twenty-Two and Twenty Twenty-Five.allowScriptsdenies every install script except the three below, andstrict-allow-scriptsfails the install on unreviewed ones.test-and-zip-default-themes.ymlnow uses thesetup-npmaction.Approved install scripts
gifsicle,jpegtran-binandoptipng-binare approved becausegrunt precommit:imagefails withENOENTwithout the binaries they fetch.Next steps
grunt-contrib-imagemin, unmaintained since 2022, or dropprecommit:image.Trac ticket:
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Implementation and this description, reviewed by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.