Skip to content

Fix alignment of delete link and update edit tag actions to use flexbox#11823

Closed
USERSATOSHI wants to merge 2 commits into
WordPress:trunkfrom
USERSATOSHI:try/fix-tag-delete-alignment
Closed

Fix alignment of delete link and update edit tag actions to use flexbox#11823
USERSATOSHI wants to merge 2 commits into
WordPress:trunkfrom
USERSATOSHI:try/fix-tag-delete-alignment

Conversation

@USERSATOSHI
Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/65233

This PR fixes the alignment of delete button after the standardization of 40px in buttons.

More details are on the issue but a before and after is below:

Before After

Use of AI Tools

AI assistance: Yes
Tool(s): Github Copilot
Model: Claude Haiku 4.5
Used for: finding where the css for delete link and tags are present, the css addition and removal is done and reviewed by me


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@USERSATOSHI
Copy link
Copy Markdown
Author

This is reproducible from my end, when following the steps provided in the issue.

image

Copy link
Copy Markdown
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. What are your thoughts on migrating entirely to a flex layout?

diff --git a/src/wp-admin/css/common.css b/src/wp-admin/css/common.css
index fa71808742..55b721e7f1 100644
--- a/src/wp-admin/css/common.css
+++ b/src/wp-admin/css/common.css
@@ -942,13 +942,6 @@ a#remove-post-thumbnail:hover,
        line-height: 2.30769231; /* 30px */
 }
 
-#delete-link {
-       line-height: 2.30769231; /* 30px */
-       vertical-align: middle;
-       text-align: left;
-       margin-left: 8px;
-}
-
 #delete-link a {
        text-decoration: none;
 }
diff --git a/src/wp-admin/css/edit.css b/src/wp-admin/css/edit.css
index aa0ecc6994..0a38c70834 100644
--- a/src/wp-admin/css/edit.css
+++ b/src/wp-admin/css/edit.css
@@ -1542,6 +1542,9 @@ p.popular-tags a {
 }
 
 .edit-tag-actions {
+       display: flex;
+       align-items: center;
+       gap: 8px;
        margin-top: 20px;
 }

@USERSATOSHI
Copy link
Copy Markdown
Author

Hi, and yeah, I also think migrating to a full flex layout seems like the right choice since many files are now using display: flex, based on the grep.

I wasn’t sure how much of this was allowed in this case, so I added flex to the .edit-tag-actions.

I will check whether fully migrating to a flex layout breaks anything before I commit this.

@USERSATOSHI
Copy link
Copy Markdown
Author

and just to confirm, I also need to update the -rtl.css files?
cc: @t-hamano

@USERSATOSHI
Copy link
Copy Markdown
Author

The diff is working, and I also checked other places just in case, so I’m committing this.

image

Copy link
Copy Markdown
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@USERSATOSHI USERSATOSHI marked this pull request as ready for review May 13, 2026 10:45
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props tusharbharti, wildworks, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Screenshot 2026-05-13 at 4 17 10 PM

@USERSATOSHI
Copy link
Copy Markdown
Author

and just to confirm, I also need to update the -rtl.css files?

Found the grunt cmd for this 👍🏻

@github-actions
Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62357
GitHub commit: 860e5fa

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants