Fix alignment of delete link and update edit tag actions to use flexbox#11823
Fix alignment of delete link and update edit tag actions to use flexbox#11823USERSATOSHI wants to merge 2 commits into
Conversation
…ox for better layout
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR. What are your thoughts on migrating entirely to a flex layout?
diff --git a/src/wp-admin/css/common.css b/src/wp-admin/css/common.css
index fa71808742..55b721e7f1 100644
--- a/src/wp-admin/css/common.css
+++ b/src/wp-admin/css/common.css
@@ -942,13 +942,6 @@ a#remove-post-thumbnail:hover,
line-height: 2.30769231; /* 30px */
}
-#delete-link {
- line-height: 2.30769231; /* 30px */
- vertical-align: middle;
- text-align: left;
- margin-left: 8px;
-}
-
#delete-link a {
text-decoration: none;
}
diff --git a/src/wp-admin/css/edit.css b/src/wp-admin/css/edit.css
index aa0ecc6994..0a38c70834 100644
--- a/src/wp-admin/css/edit.css
+++ b/src/wp-admin/css/edit.css
@@ -1542,6 +1542,9 @@ p.popular-tags a {
}
.edit-tag-actions {
+ display: flex;
+ align-items: center;
+ gap: 8px;
margin-top: 20px;
}|
Hi, and yeah, I also think migrating to a full flex layout seems like the right choice since many files are now using I wasn’t sure how much of this was allowed in this case, so I added I will check whether fully migrating to a flex layout breaks anything before I commit this. |
|
and just to confirm, I also need to update the -rtl.css files? |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Found the grunt cmd for this 👍🏻 |



Trac ticket: https://core.trac.wordpress.org/ticket/65233
This PR fixes the alignment of delete button after the standardization of 40px in buttons.
More details are on the issue but a before and after is below:
Use of AI Tools
AI assistance: Yes
Tool(s): Github Copilot
Model: Claude Haiku 4.5
Used for: finding where the css for delete link and tags are present, the css addition and removal is done and reviewed by me
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.