Repository navigation
Fix memory64 passing of (rep i64) for borrows - #754
Open
lukewagner wants to merge 1 commit into
Open
lukewagner wants to merge 1 commit into
lukewagner wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fills in a case we missed in #624 (which added 🐘-gated memory64 support) which is, when a
(borrow $R)handle is passed to the component that defined$R, the (i64)repvalue must be passed instead of thei32handle index. This involved plumbing theLiftLowerContextdown intoalignmentandelem_size(which were previously invariant, but now care about the direction and current-instance) and adding thelift/lowerdirection toLiftLowerContext. This allowed a bit of tidying up to make things less verbose.