[MakeSharedObjects] Lower externrefs using a dynamically grown table - #9114
Merged
Merged
Conversation
Because arbitrary unshared externrefs cannot be made shared directly, lower unshared externrefs to shared i31ref table indices using a LazyTable abstraction that manages the table and runtime conversion helpers on demand. Unlike function references, externrefs are still passed across the module boundary, so wrap imported and exported functions that accept or return externrefs to convert between externrefs and table indices. Also lower any.convert_extern and extern.convert_any using imported conversion helpers, and check that table.grow succeeds (>= 0) when converting references to indices, trapping otherwise.
kripken
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because arbitrary unshared externrefs cannot be made shared directly,
lower unshared externrefs to shared i31ref table indices using a
LazyTable abstraction that manages the table and runtime conversion
helpers on demand.
Unlike function references, externrefs are still passed across the
module boundary, so wrap imported and exported functions that accept or
return externrefs to convert between externrefs and table indices. Also
lower any.convert_extern and extern.convert_any using imported
conversion helpers, and check that table.grow succeeds (>= 0) when
converting references to indices, trapping otherwise.