Add filter for alternative authorization header#76
Open
abhishek-kaushik wants to merge 3 commits into
Open
Conversation
abhishek-kaushik
changed the title
joehoyle
requested changes
May 12, 2026
| * @return string|null Authorization header if set, null otherwise | ||
| */ | ||
| function get_authorization_header() { | ||
| if ( ! empty( $_SERVER['HTTP_AUTHORIZATION'] ) ) { |
Member
There was a problem hiding this comment.
Wouldn't it be better to just pass the header name through a filter at this point? $header = apply_filters( 'oauth2.authentication.authorization_header', 'authorization' ) for example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the hardcoded `Authorization` header lookup with a filterable header name, allowing projects to redirect token extraction to a different header when the standard one is consumed by a proxy or server layer (e.g. Imperva HTTP Basic Auth).
A `get_header( $name )` helper is extracted so the same `$_SERVER` + `getallheaders()` fallback logic applies regardless of which header name is used.
Usage
```php
add_filter( 'oauth2.authentication.authorization_header', function() {
return 'x-authorization';
} );
```
Why
Hardcoding `X-Authorization` as a fallback in the plugin is too opinionated — the header name is environment-specific and belongs at the project level, not the library level.