Do not let a clipboard failure replace the snapshot diff - #1907
Merged
Conversation
The clipboard write runs from the OnFirstVerify and OnVerifyMismatch callbacks, which the engine awaits while building the failure, and nothing guarded it. So ClipboardService throwing replaced the snapshot diff with an unrelated error: no xsel or wl-copy on a headless Linux box, or another process holding the Windows clipboard. That is the same failure mode ClipboardEnabled already avoids for its environment variable parse. Copying the accept command is a convenience, so it now fails quietly to Trace. No test: making ClipboardService fail on demand needs an environment without a clipboard, and the alternative is injecting a writer purely to exercise a try/catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clipboard write runs from the OnFirstVerify and OnVerifyMismatch callbacks, which the engine awaits while building the failure, and nothing guarded it. So ClipboardService throwing replaced the snapshot diff with an unrelated error: no xsel or wl-copy on a headless Linux box, or another process holding the Windows clipboard.
That is the same failure mode ClipboardEnabled already avoids for its environment variable parse. Copying the accept command is a convenience, so it now fails quietly to Trace.
No test: making ClipboardService fail on demand needs an environment without a clipboard, and the alternative is injecting a writer purely to exercise a try/catch.