Always write an object for ClaimsPrincipal - #1905
Merged
Merged
Conversation
An empty ClaimsPrincipal returned without writing any token, which left the
writer in Property state after the caller had written the member name. That
threw JsonWriterException for a following member, silently emitted null in
trailing position, and produced empty output at the root.
The object is now always written. WriteMember drops the empty Identities
collection, so an empty principal renders as {}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty ClaimsPrincipal returned without writing any token, which left the writer in Property state after the caller had written the member name. That threw JsonWriterException for a following member, silently emitted null in trailing position, and produced empty output at the root.
The object is now always written. WriteMember drops the empty Identities collection, so an empty principal renders as {}.