Never report the current process as locking a file - #1904
Merged
Conversation
RmGetList includes the caller when the lock is held in process, which the new test confirms. FileLockKiller kills everything the list reports, so with Verify_KillProcessLockingFile enabled a file held open inside the test process made the test host kill itself: the run vanished with no diagnostics, and the write being retried could not have succeeded anyway. The docs describe the target as external editor and diff processes, so the current process id is now skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RmGetList includes the caller when the lock is held in process, which the new test confirms. FileLockKiller kills everything the list reports, so with Verify_KillProcessLockingFile enabled a file held open inside the test process made the test host kill itself: the run vanished with no diagnostics, and the write being retried could not have succeeded anyway.
The docs describe the target as external editor and diff processes, so the current process id is now skipped.