Run before callbacks from the file level InnerVerifier constructor - #1903
Merged
Conversation
Dispose calls RunAfterCallbacks unconditionally, and the primary constructor calls RunBeforeCallbacks, but the constructor used by third party clients to verify a file directly never did. So an OnVerify(before, after) pair registered against those settings, or globally, had only its after half executed. Anything the pair sets and restores, such as a culture, ambient state or a counter, was left unbalanced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dispose calls RunAfterCallbacks unconditionally, and the primary constructor calls RunBeforeCallbacks, but the constructor used by third party clients to verify a file directly never did.
So an OnVerify(before, after) pair registered against those settings, or globally, had only its after half executed. Anything the pair sets and restores, such as a culture, ambient state or a counter, was left unbalanced.