Repository navigation
fix: count a Merkl campaign once when it covers several markets - #5816
Merged
Merged
Conversation
The Venus API lists a campaign on every market it covers, so a campaign spanning several borrow markets appeared once per market in merklCampaigns. formatMerklRewardsPayload emitted one pendingReward per entry, all resolved from the same campaign breakdown, and formatRewardSummaryData summed them — reporting a claimable amount equal to the real one multiplied by the number of markets. Deduplicate the distributions by campaign id before building the summaries, so a campaign contributes its breakdown once regardless of how many markets it covers.
🦋 Changeset detectedLatest commit: 3811682 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
 |
Contributor
Coverage Report for ./apps/evm
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket(s)
VPD-XXX
Changes
Borrow U, USDT using SKHYB, NVDAB, TSLAB, SPCXB as collateral on Venus) is served on bothvUandvUSDT.getMerklCampaignskeys its output by market, so that one campaign reachedformatMerklRewardsPayloadtwice. The reducer then emitted onependingRewardper entry — each resolved from the same campaign breakdown — andformatRewardSummaryDatasummed them, so the claim modal advertised the real amount multiplied by the number of markets the campaign covers.Claimunion has no external variant andvTokenAddressesWithPendingRewardnever reaches a contract call for them, so dropping the duplicate market address is inert.Campaigns covering a single market — every Merkl campaign before this one — keep their existing behavior, which the added spec pins down alongside the multi-market case.