Repository navigation
[VPD-2108] feat: add boundary for dashboard - #5815
cuzz-venus wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 73086e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| <SectionErrorBoundary className="my-20"> | ||
| <Outlet /> | ||
| </SectionErrorBoundary> |
There was a problem hiding this comment.
Layout remains mounted when users navigate between sibling routes. If one page throws, this boundary stays in its error state and hides the destination page until the user clicks Retry or reloads. Reset the boundary when the route changes so a failure on one page does not block another page.
| <SectionErrorBoundary className="my-20"> | |
| <Outlet /> | |
| </SectionErrorBoundary> | |
| <SectionErrorBoundary key={pathname} className="my-20"> | |
| <Outlet /> | |
| </SectionErrorBoundary> |
Knowledge Base Used: Application shell and routing
Coverage Report for ./apps/evm
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
cuzz-venus
changed the title
|
|
|
@greptile review again |
| export const AreaChart = <T extends Record<string, any>>(props: AreaChartProps<T>) => ( | ||
| <SectionErrorBoundary className="my-4"> | ||
| <AreaChartContent {...props} /> | ||
| </SectionErrorBoundary> |
There was a problem hiding this comment.
AreaChartContent and AreaChart now share one file. The repository requires each component to live in its own named directory and allows at most one component per file. Move AreaChartContent into its own directory before merging. The same requirement applies to Boom and ConditionalBoom in the new boundary tests.
Context Used: AGENTS.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This branch was successfully deployed
1 participant
Jira ticket(s)
VPD-2108
Changes