This repository was archived by the owner on Oct 30, 2026. It is now read-only.
Repository navigation
Let backend adapters create fresh databases for shared tests - #3802
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared report fixture constructed a concrete mock database before passing it to an adapter. Replace that input contract with
CreateCloudDatabase, which returns read-only named credentials. Each adapter now owns construction and registration, and the sharedfresh_databasefixture delegates creation to it. Keep the concrete database-adder inside the adapter and reuse it for fresh and rate-limited databases.Towards #3738.
Validation:
git diff --checkpassed.Hosted CI will run on the published branch.