Test credential limit through the public API - #3631
Merged
Merged
Conversation
adamtheturtle
had a problem deploying
to
vuforia
September 12, 2026 15:32 — with
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The credential-limit test mutated the private
_MAX_CLIENT_CREDENTIALSmodule constant to make the store immediately full. That required importing a private module through the package and disabling Pyright private-use checking for the entire test file.Exercise the documented limit honestly instead: create 100 credentials through the HTTP API, assert that every creation succeeds, and then verify that the 101st request is rejected. The mock-only loop takes well under a second, so no test-only production seam is needed.
This removes the private import,
monkeypatch.setattr, and the file-wide Pyright suppression.Validation:
_model_target_web_api.pycoverage: 100%The combined local report remains the repository's known 99% without the separately partitioned real Vuforia backend; hosted CI combines the configured partitions and is the authoritative 100% gate.