Build typed multipart query fields - #3629
Merged
Merged
Conversation
adamtheturtle
had a problem deploying
to
vuforia
September 12, 2026 12:44 — with
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The query test helper passed heterogeneous multipart tuples directly to urllib3. Some fields intentionally contain integers and booleans, which urllib3 accepts at runtime but excludes from its annotated field value type; the helper therefore widened the whole mapping to explicit
Anyand suppressed Pyrefly.Keep
objectonly at the heterogeneous test-data boundary, validate each value against the actual supported scalar domain, normalize numeric values to their wire strings, and construct urllib3’s publicRequestFieldobjects before encoding. This removes the explicitAnyand ignore without relying on a cast or another reflective escape hatch.Validation:
The changed test module reports 99% locally only because two pre-existing branches skip mock-specific ordering assertions on the separately partitioned real backend. The new multipart construction lines are covered; CI combines the configured partitions and remains the authoritative 100% gate.