Type Model Target request handling as recursive JSON - #3624
Merged
Merged
Conversation
adamtheturtle
had a problem deploying
to
vuforia
September 12, 2026 09:35 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
September 12, 2026 09:35 — with
GitHub Actions
Failure
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Model Target request validation used Any throughout the decoded JSON tree. That hid the actual container shapes from Pyrefly and required 19 ignores around ordinary dictionary, list, string, and number operations. The view helper also retained a branch for non-object values even though the request boundary normalizes every such value before calling it; its only test had to bypass two lint rules to call the private helper directly.
Change
Use the existing recursive JSONValue domain type at the response and request boundaries, then narrow nested arrays and objects before inspecting them. OAuth and validation response bodies are also constructed as recursive JSON values. Remove the unreachable view-helper branch and its implementation-detail test. This removes 21 suppression lines without changing HTTP behavior.
Validation
The local aggregate coverage command reports 99% because real-Vuforia-only and platform paths are skipped locally; the repository hosted coverage job combines those partitions.