Skip to content

Type target manager request defaults - #3605

Merged
adamtheturtle merged 5 commits into
mainfrom
type-request-defaults
Sep 10, 2026
Merged

Type target manager request defaults#3605
adamtheturtle merged 5 commits into
mainfrom
type-request-defaults

Conversation

@adamtheturtle

Copy link
Copy Markdown
Member

The request-body validator has exactly two default-value sources: CloudDatabase.to_dict() and VuMarkDatabase.to_dict(). Type that parameter as the corresponding CloudDatabaseDict | VuMarkDatabaseDict union instead of an arbitrary Mapping[str, object].

This is independent from #3603 and does not change request parsing or validation behavior.

Local verification:

  • all five configured type checkers on target_manager.py
  • uv run prek run --all-files
  • uv run prek run --all-files --hook-stage pre-push
  • uv run pytest tests/mock_vws/test_flask_app_usage.py -k database

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant