Skip to content
This repository was archived by the owner on Oct 30, 2026. It is now read-only.

Validate target request bodies at the JSON boundary - #3591

Closed
adamtheturtle wants to merge 1 commit into
mainfrom
fix/typed-vws-target-request-bodies
Closed

Validate target request bodies at the JSON boundary#3591
adamtheturtle wants to merge 1 commit into
mainfrom
fix/typed-vws-target-request-bodies

Conversation

@adamtheturtle

@adamtheturtle adamtheturtle commented Sep 9, 2026

Copy link
Copy Markdown
Member

Parse add-target and update-target payloads through strict Pydantic adapters backed by precise TypedDict schemas. Downstream construction now receives known field types, removing 15 Pyrefly unknown-type suppressions and rejecting malformed shapes at the request boundary.\n\nValidation: every pre-commit and pre-push hook applicable to the changed module passes. The public backend tests require live Vuforia credentials locally and remain covered by hosted CI.

@adamtheturtle

adamtheturtle commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

Consolidated into #3590 so this cleanup is represented by one PR for the project.

This branch was previously deployed

2 inactive deployments
vuforia — a7cf8671 Deployed Sep 9, 2026 by adamtheturtle via ci-tests (3.14, tests/mock_vws/test_model_target_retries.py) #2134
development — a7cf8671 Deployed Sep 9, 2026 by adamtheturtle via pages #2053
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@adamtheturtle