Switch hadolint to hadolint-coatl in the dev extra - #3497
Merged
Conversation
adamtheturtle
temporarily deployed
to
development
August 26, 2026 13:22 — with
GitHub Actions
Inactive
adamtheturtle
had a problem deploying
to
vuforia
August 26, 2026 13:41 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
August 26, 2026 13:41 — with
GitHub Actions
Failure
The ``hadolint-py`` wheel published on PyPI for macOS is a corrupt archive and fails to extract, so it cannot be used as a dependency. Use ``hadolint-coatl`` instead, and run it through a ``local`` prek hook so that its version is managed alongside the other tools in the ``dev`` extra, matching how ``shellcheck`` and ``shfmt`` are handled. Closes #3427 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
Rebased onto main and dropped the That override existed because the old This PR is back to just the hadolint to hadolint-coatl switch. All prek hooks pass locally on macOS across the pre-commit, pre-push and manual stages, including the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the remote
AleksaC/hadolint-pyprek repo withhadolint-coatl==2.15.1in thedevextra, run through alocalprek hook (uv run --extra=dev hadolint) so its version is managed alongside the other tools, matching howshellcheckandshfmtare already handled.hadolint-pycould not be used as a dependency because its published macOS wheel is a corrupt archive —uvandzipfile.testzip()both fail on it withdeflate decompression error: invalid block type.Also overrides the
corrupted_image_filefixture intests/conftest.py.vws-test-fixtures2026.8.23 changed it to keep only the eight byte PNG signature, and real Vuforia answers an image with no data after the signature with a500rather than aBadImageresponse, which broketest_corruptedintest_add_target.pyandtest_update_target.pyonmain. Truncating the PNG part way through instead givesBadImagefrom real Vuforia while still being unopenable by Pillow, so the mock backends agree.One caveat:
hadolint-coatltags its macOS wheelmacosx_26_0_arm64, so contributors on older macOS or Intel Macs will not be able to install thedevextra.Closes #3427
🤖 Generated with Claude Code