Skip to content

Revert "ci: skip Real Vuforia on pull requests" (#3484) - #3485

Merged
adamtheturtle merged 1 commit into
mainfrom
revert-3484
Aug 25, 2026
Merged

Revert "ci: skip Real Vuforia on pull requests" (#3484)#3485
adamtheturtle merged 1 commit into
mainfrom
revert-3484

Conversation

@adamtheturtle

Copy link
Copy Markdown
Member

Reverts #3484 (merge commit af8bee5).

Restores the previous .github/workflows/test.yml behaviour:

  • Real Vuforia backends run on pull_request again (no conditional --skip-real).
  • The coverage gate is a hard 100% on every event (no report.fail_under rewrite on PRs).

🤖 Generated with Claude Code

https://claude.ai/code/session_018x8C5AEJPVyoGeQESTtMRq

@adamtheturtle

Copy link
Copy Markdown
Member Author

This revert brings back Real Vuforia on PRs, which currently fails with ProjectSuspendedError on a stable set of matrix cells (same SECRET_INDEX each run — e.g. secrets for TestIncludeTargetData / test_model_target_web_api).

Until those Vuforia projects are replaced/unsuspended in ci_secrets, PR Test cannot go green with Real backends enabled. #3484’s skip-real-on-PR path is what lets Dependabot land.

Happy to help once credentials are refreshed, or to explore a narrower approach (denylist of suspended secret slots) if preferred over skipping Real on PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant