trunk shadow changes: com.unity.netcode.gameobjects

[pets-svc]

This PR contains changes made to the trunk copy of com.unity.netcode.gameobjects.

This usually means that breaking changes has landed in the trunk Editor, necessitating matching changes to your package code. trunk is therefore currently running CI tests with the modified shadow package instead of your real package. You must integrate these changes into your package (while maintaining compatibility with older versions of Unity supported by your package), release a new version, and land the new version in the editor manifest before the Package RC deadline, as your package otherwise will not be compatible with the released Editor.

The bot commit was created on top of the package release commit, and so this PR contains unrelated older commits. You may need to change the PR target branch (by clicking the pencil icon next to the PR title), or cherrypick the commit to a freshly created branch.

Is this automation useful? Let us know on #devs-pets, where you can also ask any question you might have about shadow packages or this automation.

Note: The shadow-package/com.unity.netcode.gameobjects branch may be force-pushed by automation at any time. If you want to make changes before landing this PR, create your own branch (and PR) to avoid automation overwriting your changes:

git fetch origin shadow-package/com.unity.netcode.gameobjects:mybranch
git checkout mybranch

If further changes are made to the shadow package on trunk, this PR will be updated if still open, or else a new PR will be opened.

[cla-assistant-unity]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[codecov-github-com]

Codecov Report

All modified and coverable lines are covered by tests ✅

@@                Coverage Diff                @@
##           develop-2.0.0    #4120      +/-   ##
=================================================
- Coverage          73.94%   73.92%   -0.03%     
=================================================
  Files                172      172              
  Lines              28099    28099              
=================================================
- Hits               20779    20772       -7     
- Misses              7320     7327       +7     

Flag	Coverage Δ
NGOv2_project_testproject_ubuntu_pinnedTrunk	73.65% <ø> (?)
NGOv2_project_testproject_ubuntu_trunk	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Components	Coverage Δ
com.unity.netcode.gameobjects	73.92% <ø> (-0.03%)	⬇️

ℹ️ Need help interpreting these results?

[EmandM]

I'm approving the C# changes, but I think @michalChrobot you'll want to take a look at the change in manifest_update.py. It looks like an unrelated change but I'm not sure.

[michalChrobot]

Yeah, I'm taking a look now (need to resolve the merge conflict + script compilation failure)

[michalChrobot]

Interesting issue here because UnityCoreClrExplicitDisabled is trunk specific and doesn't exist in our repo. I will investigate how to add this

[michalChrobot]

It should be fixed now, I will see once the job pass if it works correctly (those tests should run as usual in our current testing)