Repository navigation
Conversation
Lazy grids skipped the construction-time merge, so chunks= changed the topology. Remap and collapse connectivity blockwise so it stays lazy. Fixes #1905
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1905
Please merge after #1870. That PR adds a strict xfail for this bug, and this fix turns it into an XPASS failure. Once #1870 lands I'll rebase and drop the marker here, so the fix and its test go in together.
Overview
Chunked grids skipped the coincident-node merge from #1692, so
chunks=changed the topology (n_edge,==,validate()). The merge now runs for lazy grids as well: the 1-D node coordinates are loaded for the search, and the connectivity is remapped blockwise withmap_blocks, so it is never computed at open time._prepare_for_dualis removed because grids are now canonical at construction.PR Checklist
General
Testing & Benchmarking
Documentation and Examples
docs/api.rst; internal (private) function names start with an underscore (_)AI Disclosure
AI Usage: