Repository navigation
Conversation
Exodus element blocks are homogeneous, so `_encode_exodus` regroups a mixed mesh by face size. Nothing recorded that permutation, so the mesh reloaded reordered -- intact, but with any face-centered data now describing the wrong faces, and no error to say so. Carry each face's original position through the regrouping and write it to `elem_num_map`, then undo the permutation on read. Exodus defines `elem_num_map` as a user-facing element ID rather than a position, so the reader only honors it on files this writer produced, identified via `qa_records`, and only when the IDs form a genuine permutation. This restores the exact-order assertions in `test_mixed_exodus` and `test_grid_ugrid_exodus_roundtrip` that the previous commit had to relax. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1910
Overview
Exodus element blocks are homogeneous, so
_encode_exodusregroups a mixed mesh by face size. Nothing recorded that permutation, so the mesh reloaded reordered -- intact, but with any face-centered data now describing the wrong faces, and no error to say so.Carry each face's original position through the regrouping and write it to
elem_num_map, then undo the permutation on read. Exodus defineselem_num_mapas a user-facing element ID rather than a position, so the reader only honors it on files this writer produced, identified viaqa_records, and only when the IDs form a genuine permutation.This restores the exact-order assertions in
test_mixed_exodusandtest_grid_ugrid_exodus_roundtripthat the previous commit had to relax.PR Checklist
General
Testing & Benchmarking
Documentation and Examples
docs/api.rst; internal (private) function names start with an underscore (_)AI Disclosure
AI Usage: Claude Opus 5.5