Skip to content

deps: Bump globby from 14.1.0 to 16.2.4 - #1539

Merged
d3xter666 merged 2 commits into
mainfrom
dependabot/npm_and_yarn/globby-16.2.4
Sep 29, 2026
Merged

d3xter666 merged 2 commits into
mainfrom
dependabot/npm_and_yarn/globby-16.2.4

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

Bumps globby from 14.1.0 to 16.2.4.

Release notes

Sourced from globby's releases.

v16.2.4

  • Fix ignore option disabling the gitignore option 19e1fce

sindresorhus/globby@v16.2.3...v16.2.4

v16.2.3

  • Fix backslash-escaped .gitignore rules 5775ffb

sindresorhus/globby@v16.2.2...v16.2.3

v16.2.2

  • Fix: Do not enumerate ignored directories with gitignore option 8bf8f54

sindresorhus/globby@v16.2.1...v16.2.2

v16.2.1

  • Fix gitignore ignoring an entire checkout under an anchored ancestor path (#277) e7bd988

sindresorhus/globby@v16.2.0...v16.2.1

v16.2.0


sindresorhus/globby@v16.1.1...v16.2.0

v16.1.1

  • Fix negation patterns with absolute filesystem paths 72e9916

sindresorhus/globby@v16.1.0...v16.1.1

v16.1.0


sindresorhus/globby@v16.0.0...v16.1.0

... (truncated)

Commits

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot Bot added dependencies Automated dependency update javascript Pull requests that update Javascript code labels Aug 23, 2026
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/globby-16.2.4 branch 3 times, most recently from 89c9c37 to bb92c6c Compare August 25, 2026 13:58
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/globby-16.2.4 branch 3 times, most recently from 8faff56 to 26164dd Compare September 7, 2026 07:39
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/globby-16.2.4 branch from 26164dd to 6565a83 Compare September 14, 2026 07:28
Bumps [globby](https://github.com/sindresorhus/globby) from 14.1.0 to 16.2.4.
- [Release notes](https://github.com/sindresorhus/globby/releases)
- [Commits](sindresorhus/globby@v14.1.0...v16.2.4)

---
updated-dependencies:
- dependency-name: globby
  dependency-version: 16.2.4
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/globby-16.2.4 branch from 6565a83 to 62ab09e Compare September 14, 2026 07:48
@d3xter666

Copy link
Copy Markdown
Member

What broke and why

@ui5/fs implements builder-excludes by converting each exclude string to a negated glob pattern (!pattern) and appending it to the incoming pattern array. When the positive pattern normalises away — e.g., querying /resources/**/.library against a reader rooted at /test-resources/ — only the negated exclude remains. In globby ≤15, a negation-only pattern list returned []. In globby 16.1.0, the new expandNegationOnlyPatterns option (default true) changes that to "everything except the negated pattern", leaking unrelated files through the adapter. Those stray resources propagated into the Link reader and caused a hard TypeError in ReaderCollectionPrioritized.

The fix

Three small edits in @ui5/fs:

  1. FileSystem._runGlob — add expandNegationOnlyPatterns: false to the globby options object. Restores pre-16 semantics with a single line.
  2. Link._byGlob — append .filter(Boolean) so any resource outside the mapped path is dropped rather than left as an undefined hole (defensive hardening).
  3. FileSystem._runGlob — add the missing return after resolve(null) on the null-relPath branch (defensive hardening).

A regression test locks the negation-only semantics against future globby bumps.

No breaking change for third parties

@ui5/fs does not forward byGlob options to globby (by design), so task and middleware authors cannot inject globby options and are unaffected. We have analyzed ui5-community/ui5-ecosystem-showcase (12 tasks/middlewares) and confirmed zero direct globby dependencies and zero negation-only patterns.

@d3xter666
d3xter666 requested a review from a team September 28, 2026 13:40

@matz3 matz3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matz3
matz3 requested review from a team and RandomByte September 28, 2026 14:18
@d3xter666
d3xter666 merged commit 59640d1 into main Sep 29, 2026
77 checks passed
@d3xter666
d3xter666 deleted the dependabot/npm_and_yarn/globby-16.2.4 branch September 29, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Automated dependency update javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants