Editor V3

.github/actions/commit-push/action.yml

@@ -0,0 +1,18 @@
+name: Commit and push
+description: Commit all changes with the github-actions bot and push, reporting whether anything was pushed
+inputs:
+  message:
+    description: Commit message (the run number is appended)
+    required: true
+outputs:
+  pushed:
+    description: 'true if a commit was pushed, otherwise false'
+    value: ${{ steps.commit.outputs.pushed }}
+runs:
+  using: composite
+  steps:
+    - id: commit
+      shell: bash
+      env:
+        MESSAGE: ${{ inputs.message }}
+      run: node scripts/commit.js "$MESSAGE"

.github/workflows/ci.yml

@@ -0,0 +1,29 @@
+name: CI
+on:
+  workflow_dispatch:
+  workflow_call:
+  push:
+    branches:
+      - master
+    paths-ignore:
+      - 'public/**'
+      - 'firebase.json'
+  pull_request:
+    paths-ignore:
+      - 'public/**'
+jobs:
+  check:
+    name: Lint and test
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+      - uses: actions/setup-node@v5
+        with:
+          node-version: 24
+          cache: npm
+      - run: npm clean-install
+      - name: Lint
+        run: npm run lint
+      - name: Test
+        run: npm test

.github/workflows/deploy.yml

@@ -0,0 +1,20 @@
+name: Deploy to Firebase Hosting
+on:
+  workflow_call:
+    secrets:
+      FIREBASE_SERVICE_ACCOUNT:
+        description: 'Firebase Service Account'
+        required: true
+jobs:
+  build_and_deploy:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: FirebaseExtended/action-hosting-deploy@v0
+        with:
+          repoToken: '${{ secrets.GITHUB_TOKEN }}'
+          firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT }}'
+          channelId: live
+          projectId: undercard-509ba
+        env:
+          FIREBASE_CLI_PREVIEWS: hostingchannels

.github/workflows/firebase-hosting-merge.yml

@@ -1,10 +1,6 @@
 name: Deploy to Firebase Hosting on merge
 on:
-  workflow_call:
-    secrets:
-      FIREBASE_SERVICE_ACCOUNT_UNDERCARD_509BA:
-        description: 'Firebase Service Account'
-        required: true
+  workflow_dispatch:
   push:
     branches:
       - master
@@ -15,15 +11,11 @@ concurrency:
   group: deploy-${{ github.ref }}
   cancel-in-progress: false
 jobs:
-  build_and_deploy:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v3
-      - uses: FirebaseExtended/action-hosting-deploy@v0
-        with:
-          repoToken: '${{ secrets.GITHUB_TOKEN }}'
-          firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_UNDERCARD_509BA }}'
-          channelId: live
-          projectId: undercard-509ba
-        env:
-          FIREBASE_CLI_PREVIEWS: hostingchannels
+  check:
+    uses: ./.github/workflows/ci.yml
+  deploy:
+    needs: check
+    uses: ./.github/workflows/deploy.yml
+    secrets:
+      FIREBASE_SERVICE_ACCOUNT: ${{secrets.FIREBASE_SERVICE_ACCOUNT_UNDERCARD_509BA}}
+

.github/workflows/firebase-hosting-pull-request.yml

@@ -4,10 +4,13 @@ on:
     paths:
       - 'public/**'
 jobs:
+  check:
+    uses: ./.github/workflows/ci.yml
   build_and_preview:
+    needs: check
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: FirebaseExtended/action-hosting-deploy@v0
         with:
           repoToken: '${{ secrets.GITHUB_TOKEN }}'

.github/workflows/update-images.yml

@@ -19,7 +19,7 @@ jobs:
           ref: master
       - uses: actions/setup-node@v5
         with:
-          node-version: 18
+          node-version: 24
       - run: npm clean-install
       - uses: tailscale/github-action@v4
         with:
@@ -33,15 +33,14 @@ jobs:
       - name: Check for case collisions
         run: node scripts/checkCase.js
       - name: Commit and push
-        uses: EndBug/add-and-commit@v9
-        with:
-          message: 'Update images (${{ github.run_number }})'
-          pathspec_error_handling: ignore
         id: push
+        uses: ./.github/actions/commit-push
+        with:
+          message: Update images
   deploy:
     name: Trigger deploy
     needs: build
     if: needs.build.outputs.pushed == 'true' || github.event_name == 'workflow_dispatch'
-    uses: ./.github/workflows/firebase-hosting-merge.yml
+    uses: ./.github/workflows/deploy.yml
     secrets:
-      FIREBASE_SERVICE_ACCOUNT_UNDERCARD_509BA: ${{secrets.FIREBASE_SERVICE_ACCOUNT_UNDERCARD_509BA}}
+      FIREBASE_SERVICE_ACCOUNT: ${{secrets.FIREBASE_SERVICE_ACCOUNT_UNDERCARD_509BA}}

.github/workflows/update-resources.yml

@@ -1,6 +1,6 @@
 name: Update resources
 on:
-  workflow_dispatch: 
+  workflow_dispatch:
   schedule:
     - cron: 5 4 2,16 * *
 jobs:
@@ -14,12 +14,12 @@ jobs:
       pushed: ${{ steps.push.outputs.pushed }}
     steps:
       - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           ref: master
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v5
         with:
-          node-version: 16
+          node-version: 24
       - run: npm clean-install
       - uses: tailscale/github-action@v4
         with:
@@ -31,15 +31,14 @@ jobs:
         env:
           ALL_PROXY: socks5h://100.115.6.118:1080
       - name: Commit and push
-        uses: EndBug/add-and-commit@v9
-        with:
-          message: 'Update new resources (${{ github.run_number }})'
-          pathspec_error_handling: ignore
         id: push
+        uses: ./.github/actions/commit-push
+        with:
+          message: Update new resources
   deploy:
     name: Trigger deploy
     needs: build
     if: needs.build.outputs.pushed == 'true' || github.event_name == 'workflow_dispatch'
-    uses: ./.github/workflows/firebase-hosting-merge.yml
+    uses: ./.github/workflows/deploy.yml
     secrets:
-      FIREBASE_SERVICE_ACCOUNT_UNDERCARD_509BA: ${{secrets.FIREBASE_SERVICE_ACCOUNT_UNDERCARD_509BA}}
+      FIREBASE_SERVICE_ACCOUNT: ${{secrets.FIREBASE_SERVICE_ACCOUNT_UNDERCARD_509BA}}

.gitignore

@@ -69,4 +69,6 @@ functions/package-lock.json
 functions/index.js
 
 *.ignore*
-**/skins/
+
+/public/resources/images/skins/
+/public/resources/data/skins.json