Skip to content

Added navigation icon styling - #205

Merged
louisghost merged 1 commit into
mainfrom
navigation-icons
Aug 19, 2026
Merged

Added navigation icon styling#205
louisghost merged 1 commit into
mainfrom
navigation-icons

Conversation

@louisghost

Copy link
Copy Markdown
Contributor

Summary

  • Added .nav a and .nav-icon styles so navigation icons render correctly alongside labels
  • Covers both primary (header) and secondary (footer) navigation menus

Companion to TryGhost/Ghost#28368

Test plan

  • Enable the navigationIcons lab in Ghost
  • Add a navigation item with an icon in Settings → Navigation
  • Verify icon and label align correctly in the header nav
  • Verify icon and label align correctly in the footer secondary nav
  • Check mobile navigation menu still renders correctly

Made with Cursor

Support icons rendered by Ghost's navigation helper so icon and label
align correctly in header and footer menus.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5ebc5b4f-17eb-4386-9683-7feecc1264f2

📥 Commits

Reviewing files that changed from the base of the PR and between ef95367 and 305c641.

⛔ Files ignored due to path filters (1)
  • assets/built/screen.css.map is excluded by !**/*.map
📒 Files selected for processing (2)
  • assets/built/screen.css
  • assets/css/screen.css

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

Added shared .nav a styling for inline-flex alignment, spacing, and vertical alignment. Added .nav-icon styling to size icons to 1em, prevent flex shrinking, and preserve image proportions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 305c6

This localized styling change adds navigation icon alignment without any identified merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: minimaluminium

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding navigation icon styling.
Description check ✅ Passed The description accurately describes the navigation icon styles and their use in header and footer menus.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch navigation-icons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@louisghost
louisghost merged commit d9ad1a0 into main Aug 19, 2026
6 checks passed
@louisghost
louisghost deleted the navigation-icons branch August 19, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant