Repository navigation
dbc/335: check page structure against the 3.3.5a client files - #21
Merged
Merged
Conversation
Six pages numbered every row 0; talenttab and creaturesounddata had unit32/flaot.
Fix Col numbers that pointed at the wrong column, and types that disagreed with the table. Checked against the 3.3.5a (12340) client files: SpellDispelType.InternalName and DanceMoves.Internal are strings, VocalUISounds 3-6 hold -1.
Checked each column's values in the 12340 DBC files and against wowdev.wiki: CreatureModelData footprint sizes, CreatureMovementInfo, DungeonMapChunk.MinZ, Weather.TransitionSkyBox and LightParams col 8 hold floats; CreatureModelData.FootstepShakeSize is an id; UnitBlood GroundBlood and ZoneMusic.Name are strings. Replace the NULL types in SoundSamplePreferences (those columns are always 0) and fix ZoneMusic field anchors.
GameObjectArtKit has four attach models, SkillLineCategory and TaxiNodes have 17-column locstrings, SpellItemEnchantmentCondition has five of each operand group, and SpellVisualKit ends with a Flags column. WorldChunkSounds stores no ID column in 3.3.5a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked every
files/DBC/335page against the 3.3.5a (build 12340) client DBC files: column count, record size, field types and theCol:lines in the descriptions. All 246 pages with a client file now match.unit32/flaottypos.Col:lines and anchors that did not match their tables (DeathThudLookups, WeaponSwingSounds2, SpellDispelType, DanceMoves, LightParams, and others).NULLtypes replaced.Flagscolumn), WorldChunkSounds (no ID column).Values and references were not checked, only structure.
:x:(unused) marks were left as they were.To do before merging
GeneratedIDwas removed because the file has 9 columns (36 bytes) and the client struct is 40 bytes; the client probably creates the ID at load. Not proven.Flags, but it holds floats (1.0, 0.9, 0.7, 0.5, 0). The name is probably wrong.OcclusionLFRatio.Opened as a draft so the auto-merge workflow leaves it alone until the list is done.