Feat/coreboot submodule#27
Open
hanetzer wants to merge 2 commits into
Open
Conversation
hanetzer
force-pushed
the
feat/coreboot_submodule
branch
from
23542e3 to
a6feb7d
Compare
Signed-off-by: Marty E. Plummer <hanetzer@startmail.com>
hanetzer
force-pushed
the
feat/coreboot_submodule
branch
from
a6feb7d to
c9c7524
Compare
Should allow us to use slrt.h in skinit.c when building for coreboot. Signed-off-by: Marty E. Plummer <hanetzer@startmail.com>
Member
|
All other projects just copy the declarations. This means duplication but it's more upstreamable and allows project-specific changes. The approach presented here works only for AMD but coreboot will need Intel declarations as well which are not present in SKL. So I think that just copying the file to coreboot is a better approach, even if not ideal. |
Author
|
just going by the TODO: include tags.h from SKL somehow that was there when I started. |
Member
Oh, sorry, it was an old TODO and SLRT is now used for all platforms, not just on AMD. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change to allow usage of the slrt.h header while building skinit in coreboot. May be a bit bodgy but you get the goal, if you have a better suggestion let me know.