You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@zeotrix Great work on this! I had to rebase to dev to resolve some merge conflicts, assuming it passes CI I will merge
Thanks! I appreciate you handling the rebase. I'll keep an eye on the CI results. If any issues or regressions show up, feel free to tag me or assign them to me and I'll investigate.
@zeotrix Great work on this! I had to rebase to dev to resolve some merge conflicts, assuming it passes CI I will merge
Thanks! I appreciate you handling the rebase. I'll keep an eye on the CI results. If any issues or regressions show up, feel free to tag me or assign them to me and I'll investigate.
I try to handle any rebases that touch the supported_models doc, it can get hairy when a lot of people are adding to it at once. It is looking like everything will pass! I will rerun the Bridge_Evals_Demo once Full Coverage completes, which should clear your one failure that was caused by those pesky 429 errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds TransformerBridge support for
Glm4MoeForCausalLM, covering the Z.ai GLM-4.5 / 4.6 / 4.7 MoE family.This includes:
trl-internal-testing/tiny-Glm4MoeForCausalLM.verify_modelscleanup guard so non-MPS machines do not call MPS synchronization during CPU verification.Closes #1404
Type of change
Screenshots
Not applicable.
Checklist:
Validation