Repository navigation
Preserve package groups in cquery - #642
Merged
tinder-maxwellelliott merged 1 commit intoNov 10, 2026
Merged
tinder-maxwellelliott merged 1 commit into
tinder-maxwellelliott merged 1 commit into
Conversation
Adding an allowed package to a visibility group can leave get-impacted-targets empty under --useCquery. Bazel returns no provider dictionary for a package group, so the compatibility query discards its label before the group can contribute to the configured graph. Filter on IncompatiblePlatformProvider when present. Carry included package groups as null-configured inputs so a membership change reaches the enclosing group, the gated rule, and its consumers. Extend the Tinder#441 regression with an edit that keeps the existing consumer visible on both sides of the comparison.
tamird
force-pushed
the
codex/bazel-diff-cquery-package-groups-20261109
branch
from
November 10, 2026 11:23
c08fe75 to
e5668fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the visibility example from #441, adding a second allowed package lets the existing consumer build at both revisions. With
--useCquery, bazel-diff reported no impact from that edit. Bazel returns no provider dictionary for a package group, so the compatibility formatter discarded its label before the group could enter the configured graph.Filter targets that report
IncompatiblePlatformProviderand retain package groups. Record included groups as inputs in the null configuration so changes to an inner group reach its enclosing group, the rule protected by that group, and the rule’s consumer.Assisted by Codex.