Repository navigation
chore: Maven plugin offset handling, warning from deployment as logged information - #2796
Merged
Merged
Conversation
mswiderski
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The release-offset selector needs clearer user documentation and Javadoc, and warning-header logging lacks test coverage for successful initial registration.
2 open issues
What changed in this PR
This PR adds release selection and platform warning logging to the Maven plugin’s model deployment tools.
Changes:
- Add
timefold.model.offset, defaulting to0, for updates and undeployment; initial registration ignores it. - Log
X-TF-WARN-MSGresponse headers at WARN after successful registration or updates. - Add tests for default/custom offsets and update warnings.
| File | Description |
|---|---|
service/tools/maven-plugin/src/test/java/ai/timefold/solver/tools/maven/UndeployModelMojoTest.java |
Verify default and custom undeployment offsets. |
service/tools/maven-plugin/src/test/java/ai/timefold/solver/tools/maven/DeployModelMojoTest.java |
Verify offset handling and warning logging for updates. |
service/tools/maven-plugin/src/main/java/ai/timefold/solver/tools/maven/UndeployModelMojo.java |
Send the release offset with DELETE requests. |
service/tools/maven-plugin/src/main/java/ai/timefold/solver/tools/maven/DeployModelMojo.java |
Send offsets with PATCH requests and log platform warnings. |
service/tools/maven-plugin/src/main/java/ai/timefold/solver/tools/maven/AbstractPlatformModelMojo.java |
Define the shared offset parameter and default. |
Review effort: Balanced
Contributor
|
It seems the code needs to be properly formatted by a maven build. |
mswiderski
force-pushed
the
maven-pluging-offset-and-warning
branch
from
November 3, 2026 07:43
1b51a68 to
813e40d
Compare
Contributor
Author
reformatted. |
mswiderski
force-pushed
the
maven-pluging-offset-and-warning
branch
from
November 3, 2026 07:55
813e40d to
424d53d
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The documented plugin configuration uses the Maven property name instead of <offset>, leaving the offset at zero and risking updates or deletion of the latest version rather than the intended older version.
3 open issues
1 resolved since last review
Review effort: Balanced
mswiderski
force-pushed
the
maven-pluging-offset-and-warning
branch
from
November 3, 2026 08:09
424d53d to
60fd555
Compare
rsynek
approved these changes
Nov 3, 2026
rsynek
left a comment
rsynek
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding the documentation, looks good.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.