add: median of medians algorithm in maths - #14486
shubhangiisinghh wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def partition(arr: list, pivot: int) -> tuple: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/median_of_medians.py, please provide doctest for the function partition
| return low, equal, high | ||
|
|
||
|
|
||
| def median_of_medians(arr: list, k: int) -> int: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: k
for more information, see https://pre-commit.ci
|
The build failure appears to be due to pytest-run-parallel not supporting doctests (thread-unsafe label), which is a known limitation of the test runner rather than an issue with the algorithm itself. All other checks including ruff, pre-commit, build docs, and local doctest runs pass successfully. |
|
Closing "tests are failing" PRs to prepare for Hacktoberfest |
Describe your change:
Added the Median of Medians algorithm implementation.
Checklist: